Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle wrapper action check for binary artifact exception does not recognize actions pinned by hash #2477

Closed
loosebazooka opened this issue Nov 22, 2022 · 1 comment · Fixed by #4097
Labels
check/Binary-Artifacts kind/bug Something isn't working

Comments

@loosebazooka
Copy link
Contributor

loosebazooka commented Nov 22, 2022

Describe the bug
Cannot include a gradle wrapper and use the gradle/wrapper-validation-action to exempt the repo from violations if pinning the action by hash (instead of tag)

Reproduction steps
Steps to reproduce the behavior:

  1. Add gradle wrapper to repo
  2. Add gradle/wrapper-validation-action to ensure validity of the wrapper (but use a hash instead of tag)
  3. Allstar hates it

Example: sigstore/protobuf-specs#23 (comment)

Expected behavior
Allstar has no complaints.

Additional context
The action hash should be converted to a version (or compared against a version)

@anantshri
Copy link

check this too : #2357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check/Binary-Artifacts kind/bug Something isn't working
Projects
Status: Done
3 participants