Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Security benefit on having 2 or more Required Reviews no clear (Feedback) #2472

Closed
joycebrum opened this issue Nov 21, 2022 · 2 comments · Fixed by #3013
Closed
Labels
kind/enhancement New feature or request

Comments

@joycebrum
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some maintainers had raised the question about whether it is really a relevant security best practice to have 2+ Required Review (related to the branch protection check)

Describe alternatives you've considered
The Branch-Protection check explanation could talk (or at least refer) an explanation on why it is important to have 2 or more required reviews

Additional context
electron/electron#35741 (review)

@joycebrum joycebrum added the kind/enhancement New feature or request label Nov 21, 2022
@laurentsimon
Copy link
Contributor

laurentsimon commented Nov 29, 2022

To protect against insider risks: if one maintainer is compromised, an attacker can send a PR and use the compromised account to LGTM their own PRs. X LGTMs requires X compromised maintainers, which is harder.
You can also point them to slsa.dev: the source requirement will have more examples.

@joycebrum
Copy link
Contributor Author

I've created a PR #3013 to address this issue and try to make this benefit clear to the user too. Thanks for the explanation @laurentsimon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants