Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move application of Binary Artifacts Gradle Wrapper Action exception into checks/evaluation/ #2048

Closed
ethan7g opened this issue Jul 13, 2022 · 3 comments · Fixed by #3508
Closed

Comments

@ethan7g
Copy link
Contributor

ethan7g commented Jul 13, 2022

Is your feature request related to a problem? Please describe.
This is where the feature should be implemented so that log messages can reflect the exception, rather than having it be an opaque process for users. It would mean that raw/binary_artifacts returns the expected files, without special exclusions.

Describe the solution you'd like
Move the exception to checks/evaluation/binary_artifacts.go.

  • Create log messages reflecting the status of the exception so that users can see details

Describe alternatives you've considered
Current stopgap implementation is opaque and solves the immediate issue by having raw/binary_artifacts exclude gradle-wrapper.jar files from being returned when the Action is detected.

Additional context
First mentioned in #2039.

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Dec 15, 2023
@spencerschrock
Copy link
Member

Completed as part of #3508

@spencerschrock spencerschrock linked a pull request Dec 28, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants