Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix doc for Webhook check #1847

Closed
laurentsimon opened this issue Apr 19, 2022 · 5 comments
Closed

BUG: fix doc for Webhook check #1847

laurentsimon opened this issue Apr 19, 2022 · 5 comments
Assignees
Labels
good first issue Good for newcomers kind/bug Something isn't working kind/enhancement New feature or request

Comments

@laurentsimon
Copy link
Contributor

If there is no support for token authentication, consider implementing it by following [these directions](https://docs.github.com/en/developers/webhooks-and-events/webhooks/securing-your-webhooks). is mis-leading because users do not control the authentication support: the webhook service is often provided by a 3P entity.

@laurentsimon laurentsimon added kind/bug Something isn't working kind/enhancement New feature or request labels Apr 19, 2022
@Suhit-Majumdar
Copy link

Hi! Can you please suggest which file is the bug in? I will go through it and try to resolve it after going through the documentation in detail.

@laurentsimon
Copy link
Contributor Author

@spencerschrock
Copy link
Member

Can be fixed at same time as #2154

@leec94
Copy link
Contributor

leec94 commented Jul 21, 2023

i can take on this issue. is the solution to this issue to update the doc to remove that sentence? i can look at #2154 as well

@spencerschrock
Copy link
Member

i can take on this issue. is the solution to this issue to update the doc to remove that sentence? i can look at #2154 as well

I could see removing it, or clarifying what a repo owner can do. Maybe something like "check if the webhook can be configured to use auth " or "request the functionality"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants