Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests required - Vulnerabilities check #1535

Closed
naveensrinivasan opened this issue Jan 26, 2022 · 5 comments
Closed

Unit tests required - Vulnerabilities check #1535

naveensrinivasan opened this issue Jan 26, 2022 · 5 comments

Comments

@naveensrinivasan
Copy link
Member

Needs more tests for this https://codecov.io/gh/ossf/scorecard/commit/5f9fff3b20ce7eb933978c7a4f9391cb2c9b3d89

Originally posted by @naveensrinivasan in #1532 (comment)

@naveensrinivasan
Copy link
Member Author

@laurentsimon FYI

@laurentsimon
Copy link
Contributor

laurentsimon commented Jan 26, 2022

the same tests we had before are there. It should cover the same logic, maybe percentage-wise it's down because the checks/vulnerabilities.go introduced a new level of indirection/boilerplate. Which lines are not hit that use to be?

@laurentsimon
Copy link
Contributor

where do we see the coverage for a PR? I did not notice it in the main thread. Is it in a check run's details?

@naveensrinivasan
Copy link
Member Author

I know, I wish the tool was reported in the PR. I don't know why it was missing TBH.

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants