Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSSION: improvements needed by tools scorecard uses or recommends #1352

Closed
laurentsimon opened this issue Dec 3, 2021 · 7 comments
Closed
Labels
kind/enhancement New feature or request

Comments

@laurentsimon
Copy link
Contributor

This thread is a collection of issues and improvements we'd like to see in the tools scorecard uses or recommends. It was suggested by @evverx

@laurentsimon laurentsimon added the kind/enhancement New feature or request label Dec 3, 2021
@laurentsimon
Copy link
Contributor Author

laurentsimon commented Dec 3, 2021

SARIF dashboard: Display vulnerabilities that are ignored in pull requests github/codeql-action#811
Dependabot: Pinning by hash upgrade dependabot/dependabot-core#3699
Dependabot: Support for dependencies for more CICDs dependabot/dependabot-core#3675

@evverx
Copy link
Contributor

evverx commented Jan 4, 2022

I think I mentioned this elsewhere but since this issue is supposed to track issues in tools scorecard recommends I'd add a link to a couple of Dependabot issues that have been open for a long time and are unlikely to be fixed anytime soon in hopes it could maybe affect anything: systemd/systemd#21343 (comment)

@laurentsimon
Copy link
Contributor Author

Make CodeQl or scanning results publicly available, maybe via an opt-in option #1427 (comment)

@laurentsimon
Copy link
Contributor Author

Add pinning variable to GitHub starter workflows actions/starter-workflows#1301

@evverx
Copy link
Contributor

evverx commented Jan 4, 2022

It's a long shot but it would be great if LGTM could be used to analyze projects that aren't hosted on GitHub. From https://sourceware.org/bugzilla/show_bug.cgi?id=28659:

At first I thought this was pretty useful to add to our own buildbot CI setup. But it comes with a horribly proprietary license :{ "CodeQL can’t be used for automated analysis, continuous integration or continuous delivery" Sigh.

I'm not sure if it helps but that was the "elfutils" project, which I think is pretty critical since it's one of those dependencies that's basically everywhere (including systemd as it turned out :-))

@laurentsimon
Copy link
Contributor Author

actions/starter-workflows#1299, which may be on the way to be fixed by @varunsh-coder

@evverx
Copy link
Contributor

evverx commented Jan 5, 2022

If it still isn't possible to figure out whether the workflow permissions are set to "Read repository contents permission" using GH API I think it should be added to the list so that scorecard wouldn't penalize projects without explicit permissions but with that flag on much.

@ossf ossf locked and limited conversation to collaborators Feb 10, 2022
@justaugustus justaugustus converted this issue into discussion #1620 Feb 10, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants