Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add unit test for getEnabledChecks() function in cmd/root.go #1196

Closed
laurentsimon opened this issue Oct 29, 2021 · 4 comments
Closed

Feature: add unit test for getEnabledChecks() function in cmd/root.go #1196

laurentsimon opened this issue Oct 29, 2021 · 4 comments
Assignees
@laurentsimon
Labels
kind/enhancement New feature or request
Milestone
v4

Comments

@laurentsimon
Copy link
Contributor

Function getEnabledChecks() determines which checks are enabled, using a combination of 1) supported checks for the repo interface, 2) wether a policy is given or not, 3) whether --checks is passed as argument or not.

Changing this behavior would be a breaking change.
@laurentsimon laurentsimon added the kind/enhancement New feature or request label Oct 29, 2021
@laurentsimon laurentsimon self-assigned this Oct 29, 2021
@laurentsimon laurentsimon added this to the milestone v4 milestone Nov 2, 2021
@azeemshaikh38 azeemshaikh38 mentioned this issue Nov 16, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jan 2, 2022

Stale issue message

@github-actions github-actions bot closed this as completed Jan 9, 2022
@laurentsimon laurentsimon reopened this Jan 10, 2022
@laurentsimon laurentsimon reopened this Jan 18, 2022
@laurentsimon laurentsimon mentioned this issue Jan 31, 2022
Closed
@naveensrinivasan
Copy link
Member

#1735

@naveensrinivasan
Copy link
Member

#1750

@afmarcum
Copy link
Contributor

afmarcum commented Aug 9, 2023

Closing this issue as v4 has been released and related issues added since reopening this issue have also been closed.

@afmarcum afmarcum closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentsimon laurentsimon

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
v4
Development

No branches or pull requests
3 participants
@naveensrinivasan @laurentsimon @afmarcum