From bba4a265bdfe2546905de46506b80dbd8c67d93d Mon Sep 17 00:00:00 2001 From: Diogo Teles Sant'Anna Date: Tue, 19 Sep 2023 19:22:56 +0000 Subject: [PATCH] docs(branch-protection-check): adapt check description to consider requirement of require PRs to make changes It adds the new tier 2 requirement, but also specify that the "require at least 1 reviewer" will have doubled weight. Signed-off-by: Diogo Teles Sant'Anna --- docs/checks.md | 3 ++- docs/checks/internal/checks.yaml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/checks.md b/docs/checks.md index a7a130e03a6..ab709b2b955 100644 --- a/docs/checks.md +++ b/docs/checks.md @@ -112,7 +112,8 @@ Tier 1 Requirements (3/10 points): - For administrators: Include administrator for review Tier 2 Requirements (6/10 points): - - Require at least 1 reviewer for approval before merging + - For administrators: Require PRs prior to make any code changes + - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier) - For administrators: Require branch to be up to date before merging - For administrators: Require approval of the most recent reviewable push diff --git a/docs/checks/internal/checks.yaml b/docs/checks/internal/checks.yaml index 352cc1ad107..c0ee9e29926 100644 --- a/docs/checks/internal/checks.yaml +++ b/docs/checks/internal/checks.yaml @@ -201,7 +201,8 @@ checks: - For administrators: Include administrator for review Tier 2 Requirements (6/10 points): - - Require at least 1 reviewer for approval before merging + - For administrators: Require PRs prior to make any code changes + - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier) - For administrators: Require branch to be up to date before merging - For administrators: Require approval of the most recent reviewable push