From 877432068f36bc44306af36b6500b2921bf34845 Mon Sep 17 00:00:00 2001 From: Diogo Teles Sant'Anna Date: Tue, 19 Sep 2023 19:22:56 +0000 Subject: [PATCH] docs(branch-protection-check): adapt check description to consider requirement of require PRs to make changes It adds the new tier 2 requirement, but also specify that the "require at least 1 reviewer" will have doubled weight. Signed-off-by: Diogo Teles Sant'Anna --- docs/checks.md | 3 ++- docs/checks/internal/checks.yaml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/checks.md b/docs/checks.md index 7800bd13bab..242258234a9 100644 --- a/docs/checks.md +++ b/docs/checks.md @@ -111,7 +111,8 @@ Tier 1 Requirements (3/10 points): - Prevent branch deletion Tier 2 Requirements (6/10 points): - - Require at least 1 reviewer for approval before merging + - For administrators: Require PRs prior to make any code changes + - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier) - For administrators: Require branch to be up to date before merging - For administrators: Require approval of the most recent reviewable push diff --git a/docs/checks/internal/checks.yaml b/docs/checks/internal/checks.yaml index 2dbfc750a9c..55b3c154533 100644 --- a/docs/checks/internal/checks.yaml +++ b/docs/checks/internal/checks.yaml @@ -200,7 +200,8 @@ checks: - Prevent branch deletion Tier 2 Requirements (6/10 points): - - Require at least 1 reviewer for approval before merging + - For administrators: Require PRs prior to make any code changes + - Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier) - For administrators: Require branch to be up to date before merging - For administrators: Require approval of the most recent reviewable push