Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add conan.io ecosystem #101

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Dec 19, 2022

add conan.io ecosystem as an ecosystem entry in the ovs schema.

docs/schema.md Outdated
@@ -388,6 +388,7 @@ The defined ecosystems are:
| `Android` | The Android ecosystem; the `name` field is the Android component name that the patch applies to, as shown in the [Android Security Bulletins](https://source.android.com/security/bulletin) such as `Framework`, `Media Framework` and `Kernel Component`. The exhaustive list of components can be found at the [Appendix](#android-ecosystem-components). |
| `GitHub Actions` | The GitHub Actions ecosystem; the `name` field is the action's repository name with owner e.g. `{owner}/{repo}`. |
| `Pub` | The package manager for the Dart ecosystem; the `name` field is a Dart package name. |
| `conan.io` | The conan.io ecosystem for C and C++; the `name` field is a conan package name. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically stylize ecosystems the way it's typically referred to in canonical documentation.

E.g. "crates.io" per https://www.rust-lang.org/governance/teams/crates-io. PyPI per https://pypi.org.

Looking at https://conan.io, should this be "Conan", or perhaps "ConanCenter" instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conan documentation doesn't mention ecosystem at all.
google has more results for conan ecosystem than conan.io ecosystem or conancenter ecosystem. so I suppose conan ecosystem is canonical one.
conan.io is just FQDN. ConanCenter is a place where packages built and stored. it's a part of the ecosystem for sure, but it won't work without other things (like conan client).
@prince-chrismc lemme know if you agree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We generally respect capitalization, so if we go with "Conan" the C should be capitalized.

Can you explain a bit more about why ConanCenter doesn't work? The intention of these ecosystems is to unambiguously identify a package that exists in some open repository. If there are multiple repositories, then Conan on its own could be ambiguous because it's not clear to which repository a package belongs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conan is distributed by design and provides multiple repositories (remotes). e.g. everyone can easily run their own conan server. ConanCenter is just one of them.
I think it makes sense if we want to target specifically ConanCenter packages, to avoid ambiguity.
so I am changing to capiital ConanCenter then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For the purposes of OSV, referring specifically to the main Conan repo for open source packages makes the most sense.

Do we want to wait for @prince-chrismc's input as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I think we all have an agreement already

docs/schema.md Outdated Show resolved Hide resolved
docs/schema.md Outdated Show resolved Hide resolved
@SSE4 SSE4 requested a review from oliverchang January 16, 2023 03:40
@SSE4
Copy link
Contributor Author

SSE4 commented Jan 16, 2023

@oliverchang can we move this one forward? lemme know if you need anything else from me

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Approving.

@oliverchang oliverchang merged commit 0a0b7a7 into ossf:main Jan 18, 2023
@andrewpollock
Copy link
Collaborator

@SSE4 is there an advisory source OSV.dev should be importing from?

@SSE4
Copy link
Contributor Author

SSE4 commented Nov 6, 2023

@SSE4 is there an advisory source OSV.dev should be importing from?

I am sorry, but I do not understand your question completely. importing what exactly and for what purpose? are we talking about python import statement here, or something different? I have no idea what is "advisory source" in this context (I assume, you mean package source code repository?). I would be grateful if you add a little bit more context/background to your question.

/cc @memsharded & @jcar87 as conan devs (I personally no longer work for conan.io).

@andrewpollock
Copy link
Collaborator

My apologies for the confusion, I have assumed prior knowledge. I am referring to importing advisories published in the OSV format, into https://OSV.dev so that they are searchable via the web interface, and discoverable via the API.

See also https://google.github.io/osv.dev/data/ and https://google.github.io/osv.dev/architecture/

@memsharded
Copy link

Hi @andrewpollock

I am afraid we don't have such a source for vulnerabilities of ConanCenter packages. This is something that would be interesting, but we don't have it yet.

@andrewpollock
Copy link
Collaborator

I'm curious what the intent was behind getting the ecosystem added to the OSV schema?

@SSE4
Copy link
Contributor Author

SSE4 commented Nov 6, 2023

I'm curious what the intent was behind getting the ecosystem added to the OSV schema?

I was told to register conan ecosystem first here in order to proceed with this PR: google/osv-scanner#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants