Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON syslog output is not correctly cleaned #32

Closed
JeremyEinfeld opened this issue Jan 31, 2014 · 4 comments
Closed

JSON syslog output is not correctly cleaned #32

JeremyEinfeld opened this issue Jan 31, 2014 · 4 comments
Assignees
Labels

Comments

@JeremyEinfeld
Copy link

Csyslogd currently only strips quotes from json_safe_message, and ignores many other characters that are invalid in a JSON string. This often causes a failure to parse at the receiving end, most often encountered with Windows events (the use of a backslash in file paths creates invalid escape sequences and some event logs entries contain newlines and tabs).

Instead of stripping the characters, it should look for and escape (via backslash) any quotation marks, backslashes, tabs, or newlines (including the carriage return for messages from Windows agents).

@ghost ghost assigned jrossi Jan 31, 2014
@jrossi
Copy link
Member

jrossi commented Jan 31, 2014

This is a known issue and thank you for raising a github issue about.

@jrossi
Copy link
Member

jrossi commented Jan 31, 2014

If you have some time their is a pull request #2 that using a json libraray and generates json output via zeromq. This is gonna be the start to the new output framework, but might be something you can test out for now.

@reyjrar
Copy link
Member

reyjrar commented Feb 17, 2014

There's a pull request sitting with this patched, just need @jrossi to sanity check it.

@reyjrar reyjrar assigned reyjrar and unassigned jrossi Feb 17, 2014
@jrossi
Copy link
Member

jrossi commented Feb 19, 2014

#49 accepted and this is in the mainline code

@jrossi jrossi closed this as completed Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants