Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

MergingPRs.md: numbered list not rendering correctly #79

Open
damithc opened this issue Mar 18, 2017 · 3 comments
Open

MergingPRs.md: numbered list not rendering correctly #79

damithc opened this issue Mar 18, 2017 · 3 comments

Comments

@damithc
Copy link
Contributor

damithc commented Mar 18, 2017

Based on the markdown text, these three should be at the next level.

image

@damithc damithc changed the title Merging PRs: numbered list not rendering correctly MergingPRs.md: numbered list not rendering correctly Mar 18, 2017
@damithc
Copy link
Contributor Author

damithc commented Mar 18, 2017

It could be a temporary rendering problem on GitHub side a subtle bug in our markdown.

@acjh
Copy link
Contributor

acjh commented Mar 18, 2017

Not sure what changed on GitHub side, but...

2 spaces

1. Make sure
  1. Merge conflict
  1. Make sure
  2. Merge conflict

3 spaces

1. Make
   1. Merge
  1. Make
    1. Merge

@pyokagan
Copy link
Contributor

They seem to have changed their implementation to conform to their Github-flavored markdown spec. (c.f. https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown)

Though, it's a good thing they finally have a spec instead of requiring us to guess the precise syntax :-P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants