Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bmp: correctly encode path identifier in NLRI when needed #2572

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

bmp: correctly encode path identifier in NLRI when needed #2572

wants to merge 1 commit into from

Commits on Sep 6, 2022

  1. bmp: correctly encode path identifier in NLRI when needed 

    The FSM has the right decoding options. First, we change the
`marshallingOptions` field to a slice instead of a single option for
consistency with the remaining of the code (`Serialize()` and
`Parse*()` accepts several options). This is not really needed as we
only initialize a single option or none, but I suppose this may matter
in the future.

Then, we pass the decoding options to the `watchUpdateEvent` struct.
From my understanding, this is the only one needing it. When
transmitting the local RIB, we don't need to encode paths with
AddPath. And when mirroring routes, the routes are already encoded.

I am however unable to correctly pass the decoding options in the
post-policy case. I don't see an obvious way to access the FSM in this
case.
    @vincentbernat
    vincentbernat committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0f273a9 View commit details
    Browse the repository at this point in the history