Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to make sure the oscillations of the hydrostatic model are actually sinusoidal. #135

Open
arjo129 opened this issue Jan 6, 2022 · 0 comments

Comments

@arjo129
Copy link
Member

arjo129 commented Jan 6, 2022

The TEST(Stability, RestoringMoment) unit test only checks the maximum pitch but as @chapulina pointed out:

Should we check minPitch too?

It would also be interesting to check that the vehicle is actually bouncing up and down, because the current test would also pass if the
amplitude is decreasing (which shouldn't happen because we don't have hydrodynamics loaded), or even if the vehicle were stopped in
place. I'm not sure what the quickest way of testing this would be, maybe checking that the pitch rate keeps going up and down?

Original thread here: #89 (comment)

We should try to find a way to check for oscillations.

@arjo129 arjo129 changed the title Add check to make sure the oscillations of the hydrostatic model Add check to make sure the oscillations of the hydrostatic model are actually sinusoidal. Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant