-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formulae with python bindings only build against 1 version of python #2834
Comments
edited to add a 3rd option |
this is not fun, but matches what we have to do when other dependencies are updated; it shouldn't be too frequent, though it could break existing workspaces using the older python version |
the only way I can think to do this is to build each package multiple times with different |
Not sure if it is useful in this context , but in conda packages I build the C++ library and the Python library as independent CMake projects, in this way I can just build the C++ library once and the Python bindings for each python supported version, to do so I have a small patch (like https://github.com/conda-forge/gz-math-feedstock/blob/main/recipe/standalone_bindings.patch) for each project. The only exception for this is gz-sim, there to have support for systems written in Python you need to rebuild also the C++ version for each Python minor version. |
thanks, that's helpful context. I think we could consider that patch for upstream. If you don't mind, I'll cherry-pick that patch from traversaro/ign-math@d02282e and open a pull request against gz-math8 to see what other maintaienrs think |
Sure. I never did that myself as I wanted to avoid to add a patch for an untested workflow in which upstream did not have interest, and the patch was small enough that it was not problematic to mantain it downstream, but I will be happy if that is integrated upstream. |
prototyping in gazebosim/gz-math#636 and #2836 |
Currently our formulae that build python bindings use
[email protected]
(see #2580). There are python packages in homebrew-core that support multiple versions of python usingpip
(see pybind11 for example), and a few that usemeson
(see py3cairo for example).Currently this is a problem because
[email protected]
has just been made the default python version in Homebrew/homebrew-core#182840, so any CI scripts that assumewhich python
resolves to[email protected]
will cause test failures:Also, any users attempting to use python bindings on macOS will fail if they don't explicitly use
[email protected]
.Options to fix this:
The text was updated successfully, but these errors were encountered: