Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect base image changes and trigger dockerhub rebuilds #362

Closed
mikaelarguedas opened this issue Jan 31, 2020 · 2 comments
Closed

Detect base image changes and trigger dockerhub rebuilds #362

mikaelarguedas opened this issue Jan 31, 2020 · 2 comments

Comments

@mikaelarguedas
Copy link
Contributor

Follow-up of #312 (comment)

Since Dockerhub stopped triggering repos that are using official images as base image.
Autobuilds are also disabled due to dockerhub not taking the image layer tree into account for building causing e.g. desktop-full image being built before desktop.
As a result images in osrf/ros are never triggered other than manually.

Feature request:

  • Detect if any currently active image is outdated
  • Trigger rebuild of impacted images

Implementation considerations:

Logic:

  • Get the list of currently active images
  • detect if their base image is in "osrf" or "library" org
  • if base image in library: get the digest of base image
  • verify that the digest of base image is in the layer list of current image
  • if not: image outdated, trigger rebuild

Implementation details:

@ruffsl
Copy link
Member

ruffsl commented Jun 9, 2021

Related reading:

Keeping Up with Docker Official Images - https://blog.atomist.com/keeping-up-with-docker-official-images/
https://news.ycombinator.com/item?id=27436850

@mikaelarguedas
Copy link
Contributor Author

Fixed in #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants