Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom HttpClient to NewClient #5

Open
JoseAlban opened this issue Nov 5, 2024 · 0 comments
Open

Allow custom HttpClient to NewClient #5

JoseAlban opened this issue Nov 5, 2024 · 0 comments

Comments

@JoseAlban
Copy link

When creating a new client e.g.:

osocloud.NewClient(oso.LocalURL, oso.LocalAuthToken)

I can't find any way to set up a custom timeout, e.g. when running tests, I wanted this to fail quick, like 1 second, but can only rely on the long default timeout, which is annoying :(

Ideally: we can pass a custom HttpClient.
Even better, use the functional options pattern for every other option too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant