From d950af97294fd67e42642aa7977f1508647281e6 Mon Sep 17 00:00:00 2001 From: Dev Ojha Date: Fri, 3 Jun 2022 14:05:27 -0500 Subject: [PATCH 1/3] Delete the app interface --- app/app.go | 2 -- app/types.go | 40 ---------------------------------------- 2 files changed, 42 deletions(-) delete mode 100644 app/types.go diff --git a/app/app.go b/app/app.go index b9724325a06..46ef757b806 100644 --- a/app/app.go +++ b/app/app.go @@ -83,8 +83,6 @@ var ( // EmptyWasmOpts defines a type alias for a list of wasm options. EmptyWasmOpts []wasm.Option - _ App = (*OsmosisApp)(nil) - Upgrades = []upgrades.Upgrade{v4.Upgrade, v5.Upgrade, v7.Upgrade, v9.Upgrade} Forks = []upgrades.Fork{v3.Fork, v6.Fork, v8.Fork} ) diff --git a/app/types.go b/app/types.go deleted file mode 100644 index ff821ab10ac..00000000000 --- a/app/types.go +++ /dev/null @@ -1,40 +0,0 @@ -package app - -import ( - abci "github.com/tendermint/tendermint/abci/types" - - "github.com/cosmos/cosmos-sdk/codec" - servertypes "github.com/cosmos/cosmos-sdk/server/types" - sdk "github.com/cosmos/cosmos-sdk/types" -) - -// App implements the common methods for a Cosmos SDK-based application -// specific blockchain. -type App interface { - // The assigned name of the app. - Name() string - - // The application types codec. - // NOTE: This shoult be sealed before being returned. - LegacyAmino() *codec.LegacyAmino - - // Application updates every begin block. - BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock) abci.ResponseBeginBlock - - // Application updates every end block. - EndBlocker(ctx sdk.Context, req abci.RequestEndBlock) abci.ResponseEndBlock - - // Application update at chain (i.e app) initialization. - InitChainer(ctx sdk.Context, req abci.RequestInitChain) abci.ResponseInitChain - - // Loads the app at a given height. - LoadHeight(height int64) error - - // Exports the state of the application for a genesis file. - ExportAppStateAndValidators( - forZeroHeight bool, jailAllowedAddrs []string, - ) (servertypes.ExportedApp, error) - - // All the registered module account addreses. - ModuleAccountAddrs() map[string]bool -} From 5c2a5002ada1d8320e1b4dec926aa8e345f69403 Mon Sep 17 00:00:00 2001 From: Dev Ojha Date: Fri, 3 Jun 2022 14:08:00 -0500 Subject: [PATCH 2/3] Changelog update --- CHANGELOG.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1bce8ce1186..e0ba3318563 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,10 +42,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +### Breaking Changes + +#### golang API breaks + +* [#1665](https://github.com/osmosis-labs/osmosis/pull/1665) Delete app/App interface +* [#1630](https://github.com/osmosis-labs/osmosis/pull/1630) Delete the v043_temp module, now that we're on an updated SDK version. + + +### Features + * [#1312] Stableswap: Createpool logic * [#1230] Stableswap CFMM equations * [#1429] solver for multi-asset CFMM -* [#1630](https://github.com/osmosis-labs/osmosis/pull/1630) Delete the v043_temp module, now that we're on an updated SDK version. ## [v9.0.0 - Nitrogen](https://github.com/osmosis-labs/osmosis/releases/tag/v9.0.0) From 7fd0742702e6b74cf9c1ff0ec0021b45a2756ba4 Mon Sep 17 00:00:00 2001 From: Dev Ojha Date: Sun, 5 Jun 2022 10:48:58 -0500 Subject: [PATCH 3/3] Use write type interface --- app/app.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/app.go b/app/app.go index 46ef757b806..96061786818 100644 --- a/app/app.go +++ b/app/app.go @@ -28,6 +28,7 @@ import ( "github.com/cosmos/cosmos-sdk/server/api" "github.com/cosmos/cosmos-sdk/server/config" servertypes "github.com/cosmos/cosmos-sdk/server/types" + sdksimapp "github.com/cosmos/cosmos-sdk/simapp" "github.com/cosmos/cosmos-sdk/testutil/testdata" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" @@ -83,6 +84,8 @@ var ( // EmptyWasmOpts defines a type alias for a list of wasm options. EmptyWasmOpts []wasm.Option + _ sdksimapp.App = (*OsmosisApp)(nil) + Upgrades = []upgrades.Upgrade{v4.Upgrade, v5.Upgrade, v7.Upgrade, v9.Upgrade} Forks = []upgrades.Fork{v3.Fork, v6.Fork, v8.Fork} )