Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate out general poolParams in gamm module #683

Closed
mattverse opened this issue Dec 21, 2021 · 2 comments
Closed

Seperate out general poolParams in gamm module #683

mattverse opened this issue Dec 21, 2021 · 2 comments
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story

Comments

@mattverse
Copy link
Member

Currently gamm module is designed in the way that every pool-model being implemented would have their own params struct which would contain exitFee and swapFee.
There's a room to further generalize gamm module by creating a generalized poolParams struct that would contain swapFee and exitFee that all pool models could implement.

@mattverse mattverse added the C:x/gamm Changes, features and bugs related to the gamm module. label Dec 21, 2021
@mconcat
Copy link
Collaborator

mconcat commented Jan 13, 2022

I agree with this. Common params scattered around different pool models will make it hard to manage for example swapfee by the governance.

@mconcat mconcat self-assigned this Jan 13, 2022
@ValarDragon ValarDragon added the T:task ⚙️ A task belongs to a story label Mar 2, 2022
@ValarDragon
Copy link
Member

Closing this for now, lets re-consider whats the ideal to do (perhaps in a github discussion), keeping in mind that we want network liveness conditions and volatility to start being able to change swap fee

Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story
Projects
Archived in project
Development

No branches or pull requests

3 participants