Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate v1beta1 in proto files #682

Closed
mattverse opened this issue Dec 21, 2021 · 4 comments
Closed

Investigate v1beta1 in proto files #682

mattverse opened this issue Dec 21, 2021 · 4 comments
Assignees

Comments

@mattverse
Copy link
Member

Both the cosmos-sdk and osmosis repo has a convention of placing proto files of a module under a v1beta1 folder.
We want to understand the reason or functionality behind this and remove these if possible for better code-hygiene

@ValarDragon
Copy link
Member

So we should make the new gamm work use v1beta1. Also we should see why the old gamm proto files, don't include v1beta1 in their import. Thanks @ajansari95 for pointing this out, https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/gamm/v1beta1/genesis.proto#L2

We need to see if updating these is state breaking / proto breaking, or client breaking. And if so, evaluate whether its worth it or not.

@mattverse
Copy link
Member Author

Does this mean that we put all proto files under osmosis/proto/osmosis/gamm/v1beta1?

@ValarDragon
Copy link
Member

Yeah we should. But also need to figure out if we need to add v1beta1 into the import

@mattverse
Copy link
Member Author

mattverse commented Jan 11, 2022

The change of including everything under v1beta1 would be state breaking. Also, if we're putting all proto files under osmosis/proto/osmosis/gamm/v1beta1 we would also need to include v1beta1 into the import.
Luckily https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/gamm/v1beta1/genesis.proto#L2 was not included in a release, we would not have to go through a state breaking update in order to fix this.

Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants