Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename(osmomath): PrecisionDec-> DecPrecision #6466

Closed
p0mvn opened this issue Sep 20, 2023 · 5 comments · Fixed by #6521
Closed

rename(osmomath): PrecisionDec-> DecPrecision #6466

p0mvn opened this issue Sep 20, 2023 · 5 comments · Fixed by #6521
Assignees
@mattverse @pysel

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 20, 2023 

          I feel like we should change to DecPrecision at some point 🤔

Originally posted by @mattverse in #6261 (comment)
@p0mvn p0mvn mentioned this issue Sep 20, 2023
Merged
@p0mvn p0mvn changed the title I feel like we should change to DecPrecision at some point 🤔 rename(osmomath): DecWithPrecision -> DecPrecision Sep 20, 2023
@osmosis-clickup osmosis-clickup changed the title rename(osmomath): DecWithPrecision -> DecPrecision I feel like we should change to DecPrecision at some point 🤔 Sep 20, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 20, 2023
@p0mvn p0mvn changed the title I feel like we should change to DecPrecision at some point 🤔 rename(osmomath): DecWithPrecision -> DecPrecision Sep 20, 2023
@mattverse
Copy link
Member

@p0mvn Do you have thoughts on PrecisionDec vs DecPrecision?

As originally discussed in the PR, I think having the Dec Suffix is confusing, leading us to think that it is returning a Dec object thus be changed to DecPrecision (just for code sanity wise). wdyt?

@p0mvn
Copy link
Member Author

p0mvn commented Sep 22, 2023

I'm happy with the change. There is also a PrecidisionBigDec that we should update to BigDecPrecision for consistency

@pysel
Copy link
Member

pysel commented Sep 24, 2023

personally, DecPrecision sounds as if it returns Dec's precision. doesn't DecWithPrecision make more sense in this context?

@p0mvn p0mvn changed the title rename(osmomath): DecWithPrecision -> DecPrecision rename(osmomath): PrecisionDec-> DecPrecision Sep 24, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Sep 24, 2023

@pysel I think @mattverse meant renaming PrecisionDec to DecPrecision and not DecWithPrecision like originally assumed

@pysel
Copy link
Member

pysel commented Sep 24, 2023

Oh, I see! Sorry for confusion. Makes total sense then

@pysel pysel mentioned this issue Sep 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

@pysel pysel

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

osmomath: rename Precision(Big)Dec to (Big)DecPrecision osmosis-labs/osmosis
3 participants
@p0mvn @mattverse @pysel