Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CL): convert priceLimit from Dec to BigDec #6355

Closed
Tracked by #5726
p0mvn opened this issue Sep 11, 2023 · 0 comments · Fixed by #6368
Closed
Tracked by #5726

refactor(CL): convert priceLimit from Dec to BigDec #6355

p0mvn opened this issue Sep 11, 2023 · 0 comments · Fixed by #6368
Assignees
@p0mvn
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 11, 2023

Background

Since we are lowering min spot price below Dec's precision, we need to also convert priceLimit to BigDec. Otherwise, swapStrategy.ValidateSqrtPrice is unable to validate the price limit correctly

  • computeInAmtGivenOut
  • computeOutAmtGivenIn
  • setupSwapStrategy
  • swapstrategy.GetPriceLimit

And any other methods and tests.

Acceptance Criteria

  • Refactor the relevant methods
  • Update tests around this
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Sep 11, 2023
@p0mvn p0mvn self-assigned this Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 11, 2023
This was referenced Sep 11, 2023
Open
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(CL): convert priceLimit API in swaps to BigDec osmosis-labs/osmosis
1 participant
@p0mvn