Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical. Rename the old canonical to be the "upgrade threshold". For example, SpotPriceUpgradeThreshold and TickUpgradeThreshold. #6318

Open
Tracked by #5726
p0mvn opened this issue Sep 5, 2023 · 0 comments
Open
Tracked by #5726

refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical. Rename the old canonical to be the "upgrade threshold". For example, SpotPriceUpgradeThreshold and TickUpgradeThreshold. #6318

p0mvn opened this issue Sep 5, 2023 · 0 comments
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 5, 2023 •
edited
Loading

Context

While working on #5726, the new min spot price was named as V2 and the original as V1.

To improve the abstractions, rename the V2 to be the canonical min spot price

As an alternative, consider suggestion from @mattverse here: #6317 (comment)

A/C

  • Ensure that V2 min tick and min spot price are renamed to be the canonical
  • Rename the old canonical to be the "upgrade threshold". For example, SpotPriceUpgradeThreshold and TickUpgradeThreshold
  • update tests
  • update comments
  • update docs
@p0mvn p0mvn mentioned this issue Sep 5, 2023
Open
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Sep 5, 2023
@p0mvn p0mvn changed the title refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical. Rename the old canonical to be the "upgrade threshold". For example, SpotPriceUpgradeThreshold and TickUpgradeThreshold. refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical Sep 5, 2023
@osmosis-clickup osmosis-clickup changed the title refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical refactor(CL): ensure that V2 min tick and min spot price are renamed to be the canonical. Rename the old canonical to be the "upgrade threshold". For example, SpotPriceUpgradeThreshold and TickUpgradeThreshold. Sep 5, 2023
This was referenced Sep 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Status: Needs Triage 🔍
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p0mvn