[Incentives] Refactor createGauge to accomodate for CL gauges

[stackman27]

Background

After merging #4526, we pass in dummy variables to lockuptypes.QueryCondition{} for CL gauges to pass createGauge function. While we do not use any lockuptypes.QueryCondition{} parameters we pass the values so that we do not have to modify the lower level createGauge function

Suggested Design

There are couple of ways of fixing this;

1. modify createGauge to accomodate different type of pool Gauges, this will be modifying the queryCondition check in the createGauge function
2. allow lockuptypes.QueryCondition{} to be empty in createGauge function

Acceptance Criteria

• new tests as well as old tests should pass

Goals & criteria for success
e.g.

• all existing and new tests should pass

[hieuvubk]

Is this issue still available, I see we have CreateConcentratedLiquidityPoolGauge for CL gauge.
But looks like we're over checking this condition:
https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/keeper/keeper.go#L98-L101

[stackman27]

so this issues a suggestion to change this QueryCondition https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/keeper/keeper.go#L111

right now its

	lockuptypes.QueryCondition{
			LockQueryType: lockuptypes.ByTime,
			Denom:         sdk.DefaultBondDenom,
	},

which essentially is pretty useless, it was added so that we can skip this logic check (https://github.com/osmosis-labs/osmosis/blob/main/x/incentives/keeper/gauge.go#L100) because we donot really care about the lockup type for CL incentive gauges

one of the fix could be to allow lockuptypes.QueryCondition{} and still be able to run createGauge function seamlessly

[stackman27]

lmk if that makes sense, happy to explain more if not

[hieuvubk]

Make sense to me

[ValarDragon]

I believe this was handled in some of Alpins recent work