Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod verify fails on v14.x #4090

Closed
Tracked by #4622
niccoloraspa opened this issue Jan 24, 2023 · 2 comments
Closed
Tracked by #4622

go mod verify fails on v14.x #4090

niccoloraspa opened this issue Jan 24, 2023 · 2 comments

Comments

@niccoloraspa
Copy link
Member

As per title, go mod verify breaks on v14.0.0 / v14.x.

❯ go mod verify
github.com/osmosis-labs/osmosis/osmoutils : missing ziphash: open hash: no such file or directory
github.com/osmosis-labs/osmosis/x/ibc-hooks : missing ziphash: open hash: no such file or directory
github.com/osmosis-labs/osmosis/v14 : missing ziphash: open hash: no such file or directory

Steps to reproduce

git checkout v14.x
go mod verify

go version in 1.19

@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 24, 2023
@niccoloraspa niccoloraspa changed the title go mod verify breaks on v14.x go mod verify fails on v14.x Jan 24, 2023
@niccoloraspa
Copy link
Member Author

niccoloraspa commented Jan 24, 2023

If this is "expected" behavior we should change the Makefile logic as the go mod verify is a dependency of the build target and it gets triggered with the -B option:

❯  make build -Bn

echo "--> Ensure dependencies have not been modified"
go mod verify
mkdir -p /github.com/osmosis-labs/osmosis/build/
GOWORK=off go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=osmosis -X github.com/cosmos/cosmos-sdk/version.AppName=osmosisd -X github.com/cosmos/cosmos-sdk/version.Version=14.0.0-5-g2521ea2f3 -X github.com/cosmos/cosmos-sdk/version.Commit=2521ea2f38c568ff70cccb540d69f30634b58580 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -w -s' -trimpath -o /github.com/osmosis-labs/osmosis/build/ ./...

@ValarDragon
Copy link
Member

Its now fixed!

$ git checkout v14.x
Branch 'v14.x' set up to track remote branch 'v14.x' from 'origin'.
Switched to a new branch 'v14.x'
$ go mod verify
all modules verified

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants