bug(CL): write tick to state during swaps

[p0mvn]

Background

Currently, the ticks are not written back to state when they are updated during swaps.

Suggested Design

We need to make sure that ticks are updated.

Acceptance Criteria

• add tests upon fixing the problem. For example, you cannot drain the same liquidity multiple times

[mattverse]

Do ticks not get updated via https://github.com/osmosis-labs/osmosis/blob/main/x/concentrated-liquidity/swaps.go#L71?

[p0mvn]

I don't think so. Ticks would have to be updates as we cross them since they have liquidity drained.

This would have to happen at a much lower level of abstraction:

• either here:

  osmosis/x/concentrated-liquidity/tick.go

  Line 46 in f611e01

  func (k Keeper) crossTick(ctx sdk.Context, poolId uint64, tickIndex int64) (liquidityDelta sdk.Dec, err error) {

• oe here:

  osmosis/x/concentrated-liquidity/swaps.go

  Line 312 in f611e01

  liquidityNet, err := k.crossTick(ctx, p.GetId(), nextTick.Int64())

[mattverse]

Closing this issue as an outcome from investigation that the tick state does not need to get updated during swaps, instead the fee accumulators need to be updated, will post a separate issue / PR for this task