Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(osmomath): make mutative Add and Quo #3773

Closed
p0mvn opened this issue Dec 16, 2022 · 0 comments · Fixed by #3779
Closed

feat(osmomath): make mutative Add and Quo #3773

p0mvn opened this issue Dec 16, 2022 · 0 comments · Fixed by #3779
Assignees
@pysel
Labels
F: geometric-twap

Comments

@p0mvn
Copy link
Member

p0mvn commented Dec 16, 2022 •
edited
Loading

Background

We need mutative Add and Quo defined on osmomath.BigDec

Originally posted by @ValarDragon in #3708 (comment)

We alreadyhave mutative `MulMut: #3678

Suggested Design

Follow #3678 for an example on how to implement it with tests.

Modify exp2 to utilize the mutatie versions as per: https://github.com/osmosis-labs/osmosis/pull/3708/files/79beaae72f54159a82c54a7872b6053fc8ffdc5a#r1050159218

Acceptance Criteria
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Dec 16, 2022
@p0mvn p0mvn mentioned this issue Dec 16, 2022
Merged
@pysel pysel self-assigned this Dec 17, 2022
@pysel pysel mentioned this issue Dec 17, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pysel pysel

Labels
F: geometric-twap
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

osmomath: AddMut and QuoMut osmosis-labs/osmosis
2 participants
@p0mvn @pysel