Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate code from MultihopSwapExactAmountIn and EstimateMultihopSwapExactAmountIn #3386

Open
Tracked by #4622
mattverse opened this issue Nov 15, 2022 · 3 comments
Open
Tracked by #4622

De-duplicate code from MultihopSwapExactAmountIn and EstimateMultihopSwapExactAmountIn #3386

mattverse opened this issue Nov 15, 2022 · 3 comments
Labels
C:x/gamm Changes, features and bugs related to the gamm module. Good first issue T:ice-box T:ice-box-uncategorized

Comments

@mattverse
Copy link
Member

Background

#2764 (comment)

There's a lot of code duplication between MultihopSwapExactAmountIn and EstimateMultihopSwapExactAmountIn that could possibly be generalized so that we don't have so much repeating boilerplate.

Suggested Design

Create a generalized method or re-structure the two methods so that we dont have duplicated code between the two methods.

Acceptance Criteria

  • Current code duplication has been removed and the two methods have a generalized structure
@mattverse mattverse added C:x/gamm Changes, features and bugs related to the gamm module. Good first issue labels Nov 15, 2022
@mattverse mattverse mentioned this issue Nov 15, 2022
Closed
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 15, 2022
@pysel
Copy link
Member

pysel commented Nov 18, 2022

I would like to look into that

@czarcas7ic
Copy link
Member

This has been completed in the original PR

@czarcas7ic
Copy link
Member

Via this method #2764 (comment)

@czarcas7ic czarcas7ic mentioned this issue Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. Good first issue T:ice-box T:ice-box-uncategorized
Projects
Osmosis Chain Development
Status: Needs Triage 🔍
Milestone
No milestone
Development

No branches or pull requests
3 participants
@czarcas7ic @mattverse @pysel