You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SDK baseapp has a very undocumented / hard to understand dependence on new Ctx generations, that are needed for App.DeliverTx to work with the same go ctx we use in test code. This is something we reverse engineered to be correct within the simulator, and just painstakingly did for osmosis-rust.
Our go tests currently work off of a ctx that is distinct from what would be used for DeliverTx's if we used both. In #2575 we fixed one of the problems.
It remains that we need to fix the s.App.BeginBlocker(ctx, req) and s.App.EndBlocker(Ctx, req) calls, to instead be the ABCI calls s.App.BeginBlock(req) and s.App.EndBlock(req) . We likely need to ensure that the entire begin block / endblock / (optional commit) flow is happening correctly in tests. (And were exposing the sensible API's from our code)
Suggested Design
Change the beginblock + endblock calls to be ABCI method
Map the flow were doing in failing tests, understand if we have API issues or more changes that need to happen, etc.
Acceptance Criteria
We only call ABCI calls for begin/endblock in apptesting
The text was updated successfully, but these errors were encountered:
I got a problem when changing BeginBlocker to BeginBlock, especially in upgrades_test. The LastBlockHeight from the previous block's commit is required to start a new block.
Looks like we are just changing the context Header without committing
Background
The SDK baseapp has a very undocumented / hard to understand dependence on new Ctx generations, that are needed for App.DeliverTx to work with the same go ctx we use in test code. This is something we reverse engineered to be correct within the simulator, and just painstakingly did for osmosis-rust.
Our go tests currently work off of a ctx that is distinct from what would be used for DeliverTx's if we used both. In #2575 we fixed one of the problems.
It remains that we need to fix the
s.App.BeginBlocker(ctx, req)
ands.App.EndBlocker(Ctx, req)
calls, to instead be the ABCI callss.App.BeginBlock(req)
ands.App.EndBlock(req)
. We likely need to ensure that the entire begin block / endblock / (optional commit) flow is happening correctly in tests. (And were exposing the sensible API's from our code)Suggested Design
Acceptance Criteria
The text was updated successfully, but these errors were encountered: