x/gamm: return tokens joined in pool-level JoinPoolNoSwap
#2684
Labels
C:x/gamm
Changes, features and bugs related to the gamm module.
Help wanted
T:code-hygiene
T:ice-box
T:ice-box-uncategorized
Background
Our current
JoinPoolNoSwap
implementation does not let the caller know how much of the tokens they passed in were successfully joined. We get around this in the message-levelJoinPoolNoSwap
by assuming the tokens passed in are all successfully joined, which in general is a fair assumption since we only pass in amounts that are calculated to be perfect joins. Still, it is a little hacky and it would likely be cleaner to have a direct thread from the assets that were successfully joined to the amount the function returns as joined. cc: @p0mvnSuggested Design
tokensJoined
return value to pool-levelJoinPoolNoSwap
Acceptance Criteria
JoinPoolNoSwap
tests are updated to check the new return value and passThe text was updated successfully, but these errors were encountered: