Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gamm: return tokens joined in pool-level JoinPoolNoSwap #2684

Open
Tracked by #4622
AlpinYukseloglu opened this issue Sep 9, 2022 · 1 comment
Open
Tracked by #4622

x/gamm: return tokens joined in pool-level JoinPoolNoSwap #2684

AlpinYukseloglu opened this issue Sep 9, 2022 · 1 comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. Help wanted T:code-hygiene T:ice-box T:ice-box-uncategorized

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our current JoinPoolNoSwap implementation does not let the caller know how much of the tokens they passed in were successfully joined. We get around this in the message-level JoinPoolNoSwap by assuming the tokens passed in are all successfully joined, which in general is a fair assumption since we only pass in amounts that are calculated to be perfect joins. Still, it is a little hacky and it would likely be cleaner to have a direct thread from the assets that were successfully joined to the amount the function returns as joined. cc: @p0mvn

Suggested Design

  • Add tokensJoined return value to pool-level JoinPoolNoSwap

Acceptance Criteria

  • Existing JoinPoolNoSwap tests are updated to check the new return value and pass
@pysel
Copy link
Member

pysel commented Mar 31, 2023

hey @AlpinYukseloglu, wdyt about reopening #2685?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. Help wanted T:code-hygiene T:ice-box T:ice-box-uncategorized
Projects
Status: Needs Triage 🔍
Development

Successfully merging a pull request may close this issue.

3 participants