Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Whitelist for Stargate Query to use Inferred value #2627

Closed
Tracked by #4622
mattverse opened this issue Sep 7, 2022 · 3 comments
Closed
Tracked by #4622

Update Whitelist for Stargate Query to use Inferred value #2627

mattverse opened this issue Sep 7, 2022 · 3 comments

Comments

@mattverse
Copy link
Member

Background

Currently Stargate Querier Whitelist keeps a hard coded map of whitelist, using query path as keys, and the actual response proto struct as the value for the map.

For those queries we do want to whitelist, we have to go through the process of hard coding the whitelist map manually.

Suggested Design

The values we are hard coding right now should be able to be inferred using the auto generated proto files, we can create a method to extract the query path and the correct proto struct from the query.pb.go files. The implementation of this might differ depending on how we extract and infer values from the query.pb.go files, it'd be best IMO if we can infer the query path when we simply have a list of response structs.

@ThanhNhann
Copy link
Contributor

Does this issue have been assigned sir @mattverse

@mattverse
Copy link
Member Author

mattverse commented Oct 6, 2022

@ThanhNhann Please go ahead! This would be an awesome feature to have!

@ValarDragon
Copy link
Member

I believe this was fixed?

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants