Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TWAP responses, to make errors for incorrect error in time range, exposed in response #2622

Closed
Tracked by #4622
ValarDragon opened this issue Sep 6, 2022 · 2 comments

Comments

@ValarDragon
Copy link
Member

Background

We want the marker for 'potentially unsafe result' to be exposed in the query response. A go API error won't get threaded through to cosmwasm, so this data has to be in the query response field.

Suggested Design

Add a bool field for "is response unstable" to the twap queries, at the GRPC proto layer, and a test for this threading through correctly

Acceptance Criteria

@hieuvubk
Copy link
Contributor

@ValarDragon could pls add more details? Like the return condition of variable

@czarcas7ic
Copy link
Member

Believe this is addressed by spot price error that occurs when querying now

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants