Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes/chores for IBC rate limiting contract #2485

Closed
4 of 5 tasks
nicolaslara opened this issue Aug 22, 2022 · 2 comments
Closed
4 of 5 tasks

Small changes/chores for IBC rate limiting contract #2485

nicolaslara opened this issue Aug 22, 2022 · 2 comments
Assignees
@nicolaslara

Comments

@nicolaslara
Copy link
Contributor

nicolaslara commented Aug 22, 2022 •
edited
Loading

This issue tracks the changes/chores left for #2408.

  • Add a readme
  • Calculate how the rate limit would behave in the two different scenarios from these comments (base limit on current value vs value at the beginning of the period) and adapt the code for the best option
  • Use Uint256 internally for amounts (comment)
  • Upgrade to cosmwasm 1.1
  • Add a schema
@nicolaslara nicolaslara self-assigned this Aug 22, 2022
@nicolaslara
Copy link
Contributor Author

Should probably also upgrade to cosmwasm 1.1 so that we get nice Uint256 math

@nicolaslara nicolaslara mentioned this issue Oct 5, 2022
Merged
@ValarDragon
Copy link
Member

Closing this tracking issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaslara @ValarDragon