Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove legacy handler.go files #1972

Closed
p0mvn opened this issue Jul 5, 2022 · 2 comments · Fixed by #1996
Closed

refactor: remove legacy handler.go files #1972

p0mvn opened this issue Jul 5, 2022 · 2 comments · Fixed by #1996
Assignees
@alexanderbez
Labels
Good first issue T:code-hygiene

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 5, 2022

Background

From each module, we should remove legacy handler.go files.

A similar refactor was don in the SDK that can be referenced: cosmos/cosmos-sdk#9650

Acceptance Criteria

Originally posted by @alexanderbez in #1956 (comment)
@ValarDragon ValarDragon moved this to Needs Review 🔍 in Osmosis Chain Development Jul 5, 2022
@ValarDragon
Copy link
Member

Oh yikes were using this in every module, yeah we should definitely remove this.

We should do this this sprint.

@alexanderbez
Copy link
Contributor

literally just code deletion haha. I can tackle this

@alexanderbez alexanderbez self-assigned this Jul 5, 2022
@alexanderbez alexanderbez mentioned this issue Jul 7, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 7, 2022
@ValarDragon ValarDragon mentioned this issue Jul 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
Good first issue T:code-hygiene
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove legacy msg handlers osmosis-labs/osmosis
3 participants
@alexanderbez @ValarDragon @p0mvn