Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Message - ERR no delegation distribution info #1797

Closed
Tracked by #1955
cfl0ws opened this issue Jun 12, 2022 · 8 comments · Fixed by #2010
Closed
Tracked by #1955

Log Message - ERR no delegation distribution info #1797

cfl0ws opened this issue Jun 12, 2022 · 8 comments · Fixed by #2010
Assignees

Comments

@cfl0ws
Copy link

cfl0ws commented Jun 12, 2022

Background

During the network restart using v10.0.0 our logs displayed only the following message immediately after restarting osmosisd.

ERR no delegation distribution info

Upon reporting this to the Osmosis Validators discord channel, @ValarDragon explained the message was due to "no swaps in that pool" and asked me to create this issue so the log messaging could be improved.

Suggested Design

TBD

Acceptance Criteria

TBD

@SlingshotCade
Copy link

I too have run into this problem after upgrading to Osmosisd 10.0.0. Once this issue shows up in the logs then the API stops responding (port 26657). A couple times I restarted cosmovisor and it started to work again. But then the "ERR no delegation distribution info" shows up and then the server stops working. Is there any more information on this?

@ValarDragon
Copy link
Member

The API is down generally due to epoch time, which is a more a longstanding problem with queries aren't available during block execution.

@czarcas7ic czarcas7ic self-assigned this Jul 10, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 11, 2022
@mattverse mattverse reopened this Jul 13, 2022
Repository owner moved this from Done ✅ to In Progress🏃 in Osmosis Chain Development Jul 13, 2022
@mattverse
Copy link
Member

After investigation, noticed that we had this error not because the pool didn't have any swaps in between epochs, it's because we don't delete intermediary accounts. Working on a PR with the fix

@mattverse mattverse assigned mattverse and unassigned czarcas7ic Jul 13, 2022
@ValarDragon
Copy link
Member

Hrmm, don't we need to be careful wrt when we need to delete intermediary accounts? (IIRC theres something in the spec about this)

@mattverse
Copy link
Member

Can't find anything in spec as of now, the current plan im thinking of is deleting intermediary accounts that doesn't have any connections & delegations any more, I cant think of any instances where deleting can be dangerous atm.

If you feel concerned about it, we can also simply pass without returning error here?

@effofxprime
Copy link

Regarding this issue, since I also face the same error, is it possible that it's causing a performance hit that I've described here in this ticket (#2173) ?

@mattverse
Copy link
Member

Epoch has performance hit mainly because of distribution logic and internal logics that's happening in epoch time, shouldn't have relation with the error log we see here

@ValarDragon
Copy link
Member

I believe this has been fixed

@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
6 participants