You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm confused as to why expectShares is double what is in the previous test when the total liquidity isn't being doubled
The logic was the following - here we are adding 2 tokens in that have equal weights and amounts in, so the liquidity would double. In the previous case, there was only one token in.
However, it seems that these should still not be equal because after the first join we would have more shares created for one of the tokens, right? As a result, the second join would have fewer shares returned than the first one. Seems that this test is passing because of the error tolerance
This is interesting – I wonder if we can set up a case where this falls outside of error tolerance just for proper coverage? Or would it always pass due to error tolerance?
The text was updated successfully, but these errors were encountered:
p0mvn
changed the title
Create TestCalcJoinPoolShares test case to fall outside of the error tolerance
Create TestCalcJoinSingleAssetTokensIn test case to fall outside of the error tolerance
Jun 11, 2022
We need a test case to fall outside of the error tolerance for when we are testing multi token calcs by joining one after another in calcJoinSingleAssetTokensIn.
We should be able to achieve that by having large token in values relative to the pool liquidity
This is interesting – I wonder if we can set up a case where this falls outside of error tolerance just for proper coverage? Or would it always pass due to error tolerance?
Originally posted by @AlpinYukseloglu in #1721 (comment)
The text was updated successfully, but these errors were encountered: