Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][Testing] More robust regression test cases for the exact numbers in these swap methods. #1408

Closed
Tracked by #1452
p0mvn opened this issue May 4, 2022 · 2 comments
Closed
Tracked by #1452

[x/gamm][Testing] More robust regression test cases for the exact numbers in these swap methods. #1408

p0mvn opened this issue May 4, 2022 · 2 comments
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented May 4, 2022 •
edited
Loading

(Especially to show the difference between old and new JoinPoolNoSwap)
@p0mvn p0mvn mentioned this issue May 4, 2022
Closed
6 tasks
@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development May 4, 2022
@p0mvn p0mvn changed the title More robust regression test cases for the exact numbers in these swap methods. (Especially to show the difference between old and new JoinPoolNoSwap) More robust regression test cases for the exact numbers in these swap methods. May 4, 2022
@p0mvn
Copy link
Member Author

p0mvn commented May 4, 2022

@ValarDragon ,

Created this issue from the epic in #1050 to make sure that we don't have non-issue bullet points.

Please fill in the description, labels, priority, and size when you have time

@p0mvn p0mvn changed the title More robust regression test cases for the exact numbers in these swap methods. [x/gamm] More robust regression test cases for the exact numbers in these swap methods. May 9, 2022
@p0mvn p0mvn mentioned this issue May 9, 2022
Closed
7 tasks
@p0mvn p0mvn added T:tests C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story labels May 9, 2022
@p0mvn p0mvn changed the title [x/gamm] More robust regression test cases for the exact numbers in these swap methods. [x/gamm][Testing] More robust regression test cases for the exact numbers in these swap methods. May 9, 2022
@p0mvn
Copy link
Member Author

p0mvn commented May 9, 2022

Closing since doesn't make sense post v7 anymore

@p0mvn p0mvn closed this as completed May 9, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:task ⚙️ A task belongs to a story T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p0mvn