-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport IAVL to v3.1.0 and v4.2.0 #1044
Comments
Hi, I'm on this, currently working on updating the cosmos sdk stuff needed for it. PS: in the future it may make the most sense to refer to the state breaking versions as v3.x and v4.x --it is those branches that I target PR's to. When this is complete I will release an archive image for rocksdb. How high priority do we consider this? It seems like it requires a backport of state listening to cosmos-sdk v0.42.10 and this gets pretty complicated. Work is started here: https://github.com/osmosis-labs/cosmos-sdk/tree/v0.42.10-osmofast A potentially more palatable option may be to backport iavl changes to v0.16.0 I just had a look at that and it doesn't seem real great either. wdyt? Additionally, it is notable that a full sync is much, much faster with rocksdb. |
Hi @faddat Thanks so much for taking this.
Sounds good, changed the issue description to reflect this.
This is not urgent but useful to have for full sync e.g. for rocks db
Could you help me understand why that is needed? Also, I noticed that the pruning manager change was ported here. I think we can get by without it, for now, to limit the scope and make the backport easier. The pruning manager change is mainly needed to make snapshots work with rigorous pruning. For now, we can require one of the following options to do a full sync:
Let me know what you think |
I am midway through making a rocks archive node automatcially. Right. now the main holdup is that I haven't automated it yet, pretty sure that with automation it is less than 24h total sync time. |
Lets close, and target this via IAVL v1 |
Background
We would like to backport the fast storage IAVL changes to v3.x and v4.x
Being able to do this is important safety-wise and for future features. We shouldn’t be only relying on a centralized server to download archive nodes all the time.
Basically, these IAVL changes backported would allow us to sync from gen way faster from the first block. It is also important if we want to transition to a different database since we would have to replay the entire state.
Notes
Acceptance Criteria
The text was updated successfully, but these errors were encountered: