From e15fc6b1f2694537f5740716a0c34bb55e9488e4 Mon Sep 17 00:00:00 2001 From: vuong <56973102+vuong177@users.noreply.github.com> Date: Tue, 31 Jan 2023 11:24:55 +0700 Subject: [PATCH] override QueryFnName (#4132) * override QueryFnName * duplicate prepareDescriptor * add CustomFlagOverrides && make change for poolmanager cli --- osmoutils/osmocli/query_cmd_wrap.go | 1 - x/gamm/client/cli/query.go | 16 ++++++++++++---- x/poolmanager/client/cli/query.go | 16 ++++++++++++---- 3 files changed, 24 insertions(+), 9 deletions(-) diff --git a/osmoutils/osmocli/query_cmd_wrap.go b/osmoutils/osmocli/query_cmd_wrap.go index af727553408..86c8e777b2b 100644 --- a/osmoutils/osmocli/query_cmd_wrap.go +++ b/osmoutils/osmocli/query_cmd_wrap.go @@ -48,7 +48,6 @@ func QueryIndexCmd(moduleName string) *cobra.Command { func AddQueryCmd[Q proto.Message, querier any](cmd *cobra.Command, newQueryClientFn func(grpc1.ClientConn) querier, f func() (*QueryDescriptor, Q)) { desc, _ := f() - prepareDescriptor[Q](desc) subCmd := BuildQueryCli[Q](desc, newQueryClientFn) cmd.AddCommand(subCmd) } diff --git a/x/gamm/client/cli/query.go b/x/gamm/client/cli/query.go index 533a7e88a8d..edf08391c4f 100644 --- a/x/gamm/client/cli/query.go +++ b/x/gamm/client/cli/query.go @@ -41,6 +41,10 @@ func GetQueryCmd() *cobra.Command { return cmd } +var customRouterFlagOverride = map[string]string{ + "router": FlagSwapRouteDenoms, +} + func GetCmdPool() (*osmocli.QueryDescriptor, *types.QueryPoolRequest) { return &osmocli.QueryDescriptor{ Use: "pool [poolID]", @@ -203,8 +207,10 @@ func GetCmdEstimateSwapExactAmountIn() (*osmocli.QueryDescriptor, *types.QuerySw Short: "Query estimate-swap-exact-amount-in", Long: `Query estimate-swap-exact-amount-in.{{.ExampleHeader}} {{.CommandPrefix}} estimate-swap-exact-amount-in 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 stake --swap-route-pool-ids=2 --swap-route-pool-ids=3`, - ParseQuery: EstimateSwapExactAmountInParseArgs, - Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + ParseQuery: EstimateSwapExactAmountInParseArgs, + Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + QueryFnName: "EstimateSwapExactAmountIn", + CustomFlagOverrides: customRouterFlagOverride, }, &types.QuerySwapExactAmountInRequest{} } @@ -216,8 +222,10 @@ func GetCmdEstimateSwapExactAmountOut() (*osmocli.QueryDescriptor, *types.QueryS Short: "Query estimate-swap-exact-amount-out", Long: `Query estimate-swap-exact-amount-out.{{.ExampleHeader}} {{.CommandPrefix}} estimate-swap-exact-amount-out 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 stake --swap-route-pool-ids=2 --swap-route-pool-ids=3`, - ParseQuery: EstimateSwapExactAmountOutParseArgs, - Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + ParseQuery: EstimateSwapExactAmountOutParseArgs, + Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + QueryFnName: "EstimateSwapExactAmountOut", + CustomFlagOverrides: customRouterFlagOverride, }, &types.QuerySwapExactAmountOutRequest{} } diff --git a/x/poolmanager/client/cli/query.go b/x/poolmanager/client/cli/query.go index f2e836d97e1..6472b206fe7 100644 --- a/x/poolmanager/client/cli/query.go +++ b/x/poolmanager/client/cli/query.go @@ -12,6 +12,10 @@ import ( "github.com/osmosis-labs/osmosis/v14/x/poolmanager/types" ) +var customRouterFlagOverride = map[string]string{ + "router": FlagSwapRouteDenoms, +} + // GetQueryCmd returns the cli query commands for this module. func GetQueryCmd() *cobra.Command { cmd := osmocli.QueryIndexCmd(types.ModuleName) @@ -30,8 +34,10 @@ func GetCmdEstimateSwapExactAmountIn() (*osmocli.QueryDescriptor, *queryproto.Es Short: "Query estimate-swap-exact-amount-in", Long: `Query estimate-swap-exact-amount-in.{{.ExampleHeader}} {{.CommandPrefix}} estimate-swap-exact-amount-in 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 stake --swap-route-pool-ids=2 --swap-route-pool-ids=3`, - ParseQuery: EstimateSwapExactAmountInParseArgs, - Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + ParseQuery: EstimateSwapExactAmountInParseArgs, + Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + QueryFnName: "EstimateSwapExactAmountIn", + CustomFlagOverrides: customRouterFlagOverride, }, &queryproto.EstimateSwapExactAmountInRequest{} } @@ -42,8 +48,10 @@ func GetCmdEstimateSwapExactAmountOut() (*osmocli.QueryDescriptor, *queryproto.E Short: "Query estimate-swap-exact-amount-out", Long: `Query estimate-swap-exact-amount-out.{{.ExampleHeader}} {{.CommandPrefix}} estimate-swap-exact-amount-out 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 stake --swap-route-pool-ids=2 --swap-route-pool-ids=3`, - ParseQuery: EstimateSwapExactAmountOutParseArgs, - Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + ParseQuery: EstimateSwapExactAmountOutParseArgs, + Flags: osmocli.FlagDesc{RequiredFlags: []*flag.FlagSet{FlagSetMultihopSwapRoutes()}}, + QueryFnName: "EstimateSwapExactAmountOut", + CustomFlagOverrides: customRouterFlagOverride, }, &queryproto.EstimateSwapExactAmountOutRequest{} }