Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration code #4

Closed
2 tasks
ValarDragon opened this issue Jan 12, 2022 · 2 comments · Fixed by #5
Closed
2 tasks

Migration code #4

ValarDragon opened this issue Jan 12, 2022 · 2 comments · Fixed by #5
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 12, 2022

IAVL fast node migration code

  • We need to make a migrate function, that reads every 'live node' in the node db, and derives the corresponding fastNode if its a leaf, and sets it. This should be a standalone function which we can test.
  • Then we should make an automatic way to test if the binary was upgraded. One way to do this is by making an entry in the nodedb at a specific key (perhaps with a v prefix), and the value at that key be a version number. If the version doesn't exist, or if its 1, then run this migration to get the new data.
@tac0turtle
Copy link

can this also be treated as upgrade and then the fast cache will populate on its own over time? Not all data will be added but the most touched parts?

@ValarDragon
Copy link
Member Author

We can't do that and get fast iteration

@p0mvn p0mvn self-assigned this Jan 21, 2022
@p0mvn p0mvn linked a pull request Jan 21, 2022 that will close this issue
27 tasks
@p0mvn p0mvn closed this as completed in #5 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants