-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add addr:milestone support to Nominatim #3541
Comments
PS: also probably related to #69 |
The simple implementation would be to just interpret the value as an an alternative to First of all there is the question of the unit. Many uses seem to have no unit at all but the wiki page does not define a default. Is it universal that the unit comes before the number? There are at least three objects where the unit is used as a suffix. And then, there are a lot of tags, which use Then there are quite a few objects with have a It looks like we need understanding of fractional numbers here. The tagging of this also seems rather diverse. Some use a comma, might just be a tagging error. Some have additional zeros at the end. How do you search for that? Can it be interpreted as a string (meaning the zeros always have to be there) or must it be interpreted as a number (search may or may not have additional zeros). There are also combinations of |
The proposed The use of the prefix "Km." is something that is widely used in general, as this denotes the address is making reference to a milestone. It very common to refer in that form to an address which uses those markers as part of an actual address. This is mostly used as a reference only and does not necessarily read an exact distance (from a milestone) on any highway. The use of Some places around the world frequently use an additional Another common variable (mentioned already above) is the use of a 'period' or a 'comma' to define the decimals & separating the thousands. The US, Australia & Great Britain (as well as many other countries) commonly use the 'period' as a decimal separator, while the EU and yet other countries around the globe use the |
I have a different point of view. In Brazil, it is not rare to find both values, as I commented here. So, they can coexist. |
It seems @GEOtemala updated his proposal, so I think many points addressed by @lonvia are now fixed. Wrt the rest, let me say what I believe:
In those cases (as @santamariense pointed out that it is not uncommon), I believe the implementation would be one followed by the other (in Uruguay, the mentioned case, I would say the full address would be "Ruta 6 Vieja, km 33 a 34, 2".
This looks like a possible tagging error, combined with the fact in Latin America (pointed case) comma is the separator, not a dot. It seems the updated proposal addresses that, which means the value should respect what is the norm in OSM.
This also looks a mapping error. It seems it was imported, so probably these numbers were treated as strings.
Finally, this case looks the mapper preferred to use Thank you for all the comments, Sarah! The new proposal seems to address your concerns, I believe, and it was important to receive all your points. Do you have any recommendation, from Nominatim point of view, to even improve the proposal? https://community.openstreetmap.org/t/rfc-feature-proposal-addr-milestone/121295 |
Be aware that this addr:milestone "Ruta 6 Vieja, km 33 a 34, 2" is caused by importing bad quality data. The value is ill formated. The addr:milestone value (at least in Uruguay is a distance, sometimes rounded to kilometer, sometimes to hundred meters.) This km 33 a 34,2 implies an indefinition of 1.2 km, not acceptable for an address. Also, most of the time the addr:milestone data are not, and will not be in OSM database, but the info that is in OSM database are the highway=milestone nodes in the rural highways (mostly kilometer away), and the geocoding procees should be able to deduct that when a user looks for "Ruta 6 km 35.500" it means a point in "Ruta 6" in the middle of the markers for km 35 and km 36. Also the distance between markers it isn't exactly 1000 meters, it can be more, it can be less... The reverse geocoding process should also use this address data in rural areas, addr:street is the higwhay, and the addr:milestone could be estimated if there are highway=milestone nodes near the location being reverse geocoded. |
No, it isn't an error. It was an import but all the schools that have wikidata tag were curated manually. All the components of this text address are in the respective addr:* tags. |
This problem is caused by an import made by Kaart a few years ago. This should'nt be imported. |
Yes, it also looks suspect to me, but I don't know how address are formatted in Spain. |
This is the correct format in Uruguay, but i cannot extrapolate to all the countries.
This tag is somewhat not standarized until now, so sometimes the tag value is prefixed, and sometimes not. As the prefix "Km" or "Km." (the dot shouldn be there beacuse is a ISO unit, not an abvreviation) is used in spoken and written language, it should be interpreted in natural language that the following value is a distance
As the tag addr:place is used when there isn't an addr:street to tag, and addr:milestone needs and addr:street to refer, it seems that addr:place and addr:milestone should'nt be a valid combination of tags.
Common use here is to say "Km 35,500" so the addr:milestone="35.500", numerically the value of "35.500" and "35.5" is the same, but the way the people speak and write address is just that, when the data consumer sees the addr:milestone just display "Km"+addr:milestone (as a value, it should be localized with the right separator used in the language of choice)
Yes. If the proposal is that "addr:milestone" is a distance it should be in english in OSM, and only the value, no prefixes. |
Sure, no problem. We should make a list of which combination and restrictions are valid in which countries or territories, just to document clearly all this knowledge and don't keep disusing cases in posts. |
Yes, an understanding of fractional numbers is needed. Maybe the comma use should be replaced by period, but i suspect that as the comma is used in spanish written addresses, the people could, or would search for |
May I suggest that you move the discussion to https://community.openstreetmap.org/t/rfc-feature-proposal-addr-milestone/121295/10? This is a wider tagging discussion and all highly relevant for the larger OSM community. |
I would like to propose support of
addr:milestone
from Nominatim: https://wiki.openstreetmap.org/wiki/Key:addr:milestoneIt is a way to tag places that are usually in rural areas, by some highway, and have no official
addr:housenumber
, but use it as a proper address. It is usually stated in a sign/website (and even used by postal letters). Examples:Highway A-1, km 12 (fictitious)
Rodovia BR-116, km 16.5 (a place that advertises in their website this address, and uses it for postal purposes).
The proposed tagging can be seen in the last OSM link, and Nominatim probably should handle it the same way as it does with
addr:housenumber
, but also appending 'km' before theaddr:milestone
value, if it is not in miles.Rationale for this request: this happens in diverse parts of the world, but very likely people don't use it in OSM for many reasons (not officially approved, lack of support by search engines and apps etc), classic egg/chicken problem that happens in OSM all the time.
In Brazil, we are working towards a full national import of addresses, which contains millions of addresses, including several ones like this. So we are probably picking this tag to be used for those cases, and would like to see Nominatim supporting it.
Finally, we saw that there are at least 4500 cases, worldwide, that have 'km' (or similar) in
addr:housenumber
, and could benefit from this tagging.addr:milestone in Taginfo: https://taginfo.openstreetmap.org/keys/addr:milestone#overview
The text was updated successfully, but these errors were encountered: