Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOMCTC: Items in multiple regions may get pruned in intersection operation #30

Open
dbahrdt opened this issue Apr 29, 2019 · 1 comment
Assignees
Milestone

Comments

@dbahrdt
Copy link
Member

dbahrdt commented Apr 29, 2019

The old code already has this right. But the "newer" variant with out-of-memory creation still does not contain "fixes" to this problem.
Unfortunately it seems that this query might actually exist in the wild.
Hence we need to support it.

Copied from TextSearchTraits.h:
If an item spans multiple regions then the item also has to be added to the respective region search strings.
Consider the query (highway fellbach) / (highway stuttgart) which should result in all highways that are in stuttgart and fellbach.
In order for this to work correctly fellbach/stuttgart needs to deref into the enclosed full-match cells AND partial-match cells containing the items that are part of fellbach/stuttgart AND part of something else

@dbahrdt dbahrdt self-assigned this Apr 29, 2019
@dbahrdt dbahrdt added this to the diss milestone Apr 29, 2019
@dbahrdt dbahrdt changed the title OOMCTC: Support querying ways in multiple regions OOMCTC: Items in multiple regions may get pruned in intersection operation Apr 29, 2019
@dbahrdt
Copy link
Member Author

dbahrdt commented Apr 30, 2019

Implemented. Unfortunately implementing this by adding partial-match cells to region strings is not enough to support the region query. Additionally this will result in these items to be returned in item queries even though only the region has a matching string. In order to fix this we have to split the data as is the case already in the osi-compare repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant