Add a check if the surface does not match the tracktype from highway=track

[mcliquid]

Driven by this discussion from StreetComplete, I would like to introduce my idea to the Osmose Analyzer.

Short: I noticed that quite often a surface=* is mapped to a highway=track which does not match the existing tracktype=* (or the other way around). In these cases Osmose could give a information / Error. The goal should be that both entries correspond to reality and match each other.

For example:

• Warn if there's surface=asphalt and tracktype=grade4
• Warn if there's surface=gravel and tracktype=grade1
• Warn if there's tracktype=grade1 and surface=gravel

Here is a rough list of cases where this error should be triggered:
highway = track AND surface = unpaved|gravel|fine_gravel|compacted|pebblestone|dirt|earth|grass|grass_paver|mud|sand|woodchips|snow|ice|salt|rock|ground AND tracktype=grade1

highway = track AND surface = paved|asphalt|asphalt:lanes|chipseal|concrete|concrete:lanes|concrete:plates|paving_stones|sett|unhewn_cobblestone|cobblestone|cobblestone:flattened|metal|wood|stepping_stones AND tracktype = grade2|grade3|grade4|grade5

[Famlam]

Like this one?
https://osmose.openstreetmap.fr/nl/map/#item=9001&zoom=17&lat=45.820472&lon=4.345231&level=3&tags=&fixable=&issue_uuid=0ce247e1-6c65-338c-f003-40cec3fc5a80

They're already imported from JOSMs combinations.mapcss, although JOSM could add this one as well to be complete with your list:
way[tracktype][surface][tracktype=~/grade[2-5]/][surface!=grass_paver]!.unpaved_surface

[mcliquid]

Like this one?

Exactly! Thank you for the hint, found it with your help in item=9001&class=9001002
But will it only trigger if grade1 exists with unpaved? I can't find anything with grade2 to grade5 and sealed surfaces. Can this be?

[Famlam]

But will it only trigger if grade1 exists with unpaved? I can't find anything with grade2 to grade5 and sealed surfaces. Can this be?

That's what I meant with the suggestion that JOSM (and, via import of their rules, Osmose) could add this rule:
way[tracktype][surface][tracktype=~/grade[2-5]/][surface!=grass_paver]!.unpaved_surface

[mcliquid]

Thank you so much @Famlam! I've created this ticket inspired by your input: https://josm.openstreetmap.de/ticket/22102
Will the check then be automatically integrated into Osmose, so that we can close this issue here or is there still an effort on the part of Osmose backend afterwards?

[Famlam]

I think Frodrigo would've to synchronize it afterwards

[matkoniecz]

JOSM validations checking tags are from time to time imported to Osmose.

[frodrigo]

No, manual. Ping here when is done.

[Famlam]

No, manual. Ping here when is done.

Ping ;) it was merged in JOSM

[frodrigo]

No, manual. Ping here when is done.

Ping ;) it was merged in JOSM

Code update done. Will be shipped on next deploy.

[Famlam]

I think this issue can be closed as fixed?

[frodrigo]

Yes deployed.