Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bullet delimiter in waterway labels #668

Closed
1ec5 opened this issue Jan 6, 2023 · 0 comments · Fixed by #669
Closed

Missing bullet delimiter in waterway labels #668

1ec5 opened this issue Jan 6, 2023 · 0 comments · Fixed by #669
Labels
bug Something isn't working

Comments

@1ec5
Copy link
Member

1ec5 commented Jan 6, 2023

This river straddles the border between North and South Korea; the two countries have different Korean-language names for the same river. The style shows both names, attempting to replace the semicolon delimiter with a newline. However, MapLibre GL JS doesn’t support newlines in line-placed labels, since they wouldn’t have text-max-width set: mapbox/mapbox-gl-js#8575. So instead it smooshes the two names together:

Imjin River

That might not be so weird in CJK, but in other scripts that routinely separate words with spaces, users might be expecting something more explicit to separate the names, as in this river:

Amu Darya

In #666, I implemented a bullet character as the delimiter in line-placed transportation labels, but I overlooked the fact that waterway labels are also line-placed.

@1ec5 1ec5 added the bug Something isn't working label Jan 6, 2023
@1ec5 1ec5 closed this as completed in #669 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant