Skip to content

Commit

Permalink
Io 1097 - fix border, padding and margin on accordion component (#463)
Browse files Browse the repository at this point in the history
* fix padding margin and border with signed commit

* update changelog
  • Loading branch information
jonaashl authored Oct 23, 2023
1 parent 807b824 commit 7e93a6e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix issue with radio button that didn't keep the checked style after it was checked
- Fix a bug that prevents generate certain grid classes that were extended as a placeholder.
- Fix unintended padding and border on accordion

## [1.0.1] - 03.10.2023

Expand Down
14 changes: 2 additions & 12 deletions src/components/accordion/accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
&__trigger {
@extend %ods-padding-5, %ods-padding-vertical-6-breakpoint-medium, %ods-padding-horizontal-8-breakpoint-medium;

border: 0.4rem solid transparent;
border: none;
background-color: colors.$white;
color: colors.$blue-dark;
display: block;
Expand Down Expand Up @@ -62,14 +62,8 @@

&:focus-visible {
background-color: colors.$white;
border: 0.2rem solid colors.$blue-state;
color: colors.$blue-state;
outline: none;
padding: 1.44rem;

@include breakpoints.medium {
padding: 1.69rem 2.19rem;
}
outline: 0.125rem solid colors.$blue-state;
}
}

Expand Down Expand Up @@ -109,10 +103,6 @@
}
}

& .ods-collapsible-trigger:focus-visible::after {
right: 0.2rem;
}

& .ods-accordion__trigger--rotate::after {
transform: translate(-50%, -50%) rotate(180deg);
}
Expand Down

0 comments on commit 7e93a6e

Please sign in to comment.