Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying protoc binary instead of forcing to build one from scratch #5

Open
timotheecour opened this issue May 8, 2018 · 1 comment

Comments

@timotheecour
Copy link
Contributor

timotheecour commented May 8, 2018

on OSX it's just brew install protobuf ; I'd like to just be able to use that binary (eg maybe in nimcfg or initialization code or something, via protoc_binary=$homebrew_D/bin/protoc)

eg, useful in case user has some custom build of protoc, or doesn't want to recompile from scratch (time consuming: 480 seconds) etc

@oskaritimperi
Copy link
Owner

This is something that should be implemented already (maybe it's a bit undocumented :-). findCompiler() should take care of this by:

  1. checking the environment variable NIMPB_PROTOC
  2. checking if protoc is in path by using os.findExe()
  3. checking if nimpb_protoc is installed and using that if it is

We also currently have a hard dependency on nimpb_protoc in our nimble-file, but I think that could be just removed. Users can install it if they need it, if it is documented well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants