Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency to passport-oauth 1.0.0 #4

Open
jaredhanson opened this issue Aug 21, 2015 · 1 comment
Open

Update dependency to passport-oauth 1.0.0 #4

jaredhanson opened this issue Aug 21, 2015 · 1 comment

Comments

@jaredhanson
Copy link

Older versions of passport-oauth depend on Passport core, causing outdated versions of req.login to be added to the HttpRequest prototype. This interferes with newer versions of Passport that have different internals, as seen here: jaredhanson/passport#400 (comment)
@osipov
Copy link
Owner

osipov commented Aug 21, 2015

@jaredhanson thanks for bringing to my attention. working to update to the newer version of Passport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredhanson @osipov