Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for trusted HMMs #309

Closed
StefDiV opened this issue Jul 25, 2024 · 2 comments
Closed

Option for trusted HMMs #309

StefDiV opened this issue Jul 25, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@StefDiV
Copy link

StefDiV commented Jul 25, 2024

Is your feature request related to an existing issue or bug?
Similar to #295, using hmm instead of a protein set.

An option like: "--hmms: Trusted HMM to first annotate from (default '')" from prokka, so the user can provide a custom hmm or hmm database that bakta could use to derive annotation first and its not overlapped by following annotation steps.

Example: given a particular protein of interest which has been used to create and curate a hmm, bakta could take the hmm (with defined cutoff scores) to identify it first in the dataset and the annotation is preserved in the final outputs.

@StefDiV StefDiV added the enhancement New feature or request label Jul 25, 2024
@oschwengers oschwengers self-assigned this Aug 29, 2024
@oschwengers oschwengers added this to the v1.10.0 milestone Aug 29, 2024
@oschwengers
Copy link
Owner

Hi @StefDiV ,
thanks for reaching out with this. This is certainly a great idea and a feature that Bakta is currently missing. I'll put this on my lis. Hopefully for the next version, but I cannot promise yet.

@oschwengers oschwengers added feature and removed enhancement New feature or request labels Oct 10, 2024
@oschwengers
Copy link
Owner

OK, now, this is implemented and live in the main branch. If you like, you can give it an early try. This will be part of the upcoming v1.10.0 release.

Again, thanks a lot @StefDiV for bringing this up! If you have any feedback, comments or further ideas, please do not hesitate to re-open this or file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants