Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null return from Code::fallback() #498

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

szepeviktor
Copy link
Contributor

As it never returns null.

As it never returns null.
@oscarotero oscarotero merged commit 3b38c92 into oscarotero:master Sep 7, 2022
@szepeviktor szepeviktor deleted the patch-4 branch September 7, 2022 08:52
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 7, 2022

@oscarotero With few hours of work you can make Embed fully type safe. 👉🏻 @phpstan
(AFAIK Extractors need some PHP generics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants