From e5c036573945d095aa19d0bf9b40febdac62cd94 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Mon, 16 Sep 2024 10:27:22 +0200 Subject: [PATCH] Update to GAP.jl 0.11.3 resp. GAP 4.13.1 (#3688) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: ThomasBreuer Co-authored-by: Lars Göttgens --- Project.toml | 2 +- src/Groups/GAPGroups.jl | 2 +- src/Groups/cosets.jl | 2 +- src/Groups/directproducts.jl | 8 ++++---- src/Groups/homomorphisms.jl | 4 ++-- test/book/cornerstones/groups/actions.jlcon | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Project.toml b/Project.toml index 1929b36eaf8d..ad8dff36a42c 100644 --- a/Project.toml +++ b/Project.toml @@ -28,7 +28,7 @@ cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade" AbstractAlgebra = "0.42.3" AlgebraicSolving = "0.5.1" Distributed = "1.6" -GAP = "0.10.2" +GAP = "0.11.3" Hecke = "0.33.0" JSON = "^0.20, ^0.21" JSON3 = "1.13.2" diff --git a/src/Groups/GAPGroups.jl b/src/Groups/GAPGroups.jl index 93be60411a22..38547f30408c 100644 --- a/src/Groups/GAPGroups.jl +++ b/src/Groups/GAPGroups.jl @@ -1024,8 +1024,8 @@ julia> G = symmetric_group(5); julia> low_index_subgroup_classes(G, 5) 3-element Vector{GAPGroupConjClass{PermGroup, PermGroup}}: Conjugacy class of Sym(5) in G - Conjugacy class of Alt(5) in G Conjugacy class of permutation group in G + Conjugacy class of Alt(5) in G ``` """ function low_index_subgroup_classes(G::GAPGroup, n::Int) diff --git a/src/Groups/cosets.jl b/src/Groups/cosets.jl index d7942e023641..b5de363e8aa0 100644 --- a/src/Groups/cosets.jl +++ b/src/Groups/cosets.jl @@ -317,7 +317,7 @@ struct SubgroupTransversal{T<: GAPGroup, S<: GAPGroup, E<: GAPGroupElem} <: Abst X::GapObj # underlying *right* transversal in GAP end -GAP.julia_to_gap(T::SubgroupTransversal) = T.X +GAP.julia_to_gap(T::SubgroupTransversal, d::IdDict{Any,Any} = IdDict(); recursive::Bool = false) = T.X function Base.show(io::IO, ::MIME"text/plain", x::SubgroupTransversal) side = x.side === :left ? "Left" : "Right" diff --git a/src/Groups/directproducts.jl b/src/Groups/directproducts.jl index a0840d36ac2d..e6ebad783383 100644 --- a/src/Groups/directproducts.jl +++ b/src/Groups/directproducts.jl @@ -33,14 +33,14 @@ julia> elements(G) (4,5) (2,3) (2,3)(4,5) - (1,2) - (1,2)(4,5) - (1,2,3) - (1,2,3)(4,5) (1,3,2) (1,3,2)(4,5) (1,3) (1,3)(4,5) + (1,2,3) + (1,2,3)(4,5) + (1,2) + (1,2)(4,5) ``` """ function direct_product(L::AbstractVector{<:GAPGroup}; morphisms::Bool=false) diff --git a/src/Groups/homomorphisms.jl b/src/Groups/homomorphisms.jl index d05863351595..7fde4db7e19f 100644 --- a/src/Groups/homomorphisms.jl +++ b/src/Groups/homomorphisms.jl @@ -544,10 +544,10 @@ Pc group of order 6 julia> iso = isomorphism(PermGroup, G) Group homomorphism from pc group of order 6 - to permutation group of degree 6 and order 6 + to permutation group of degree 3 and order 6 julia> permutation_group(G) -Permutation group of degree 6 and order 6 +Permutation group of degree 3 and order 6 julia> codomain(iso) === ans true diff --git a/test/book/cornerstones/groups/actions.jlcon b/test/book/cornerstones/groups/actions.jlcon index cca4f30a51b5..af50427d42b8 100644 --- a/test/book/cornerstones/groups/actions.jlcon +++ b/test/book/cornerstones/groups/actions.jlcon @@ -60,10 +60,10 @@ Group homomorphism julia> isomorphism(PermGroup, U) Group homomorphism from pc group of order 8 - to permutation group of degree 8 and order 8 + to permutation group of degree 4 and order 8 julia> permutation_group(U) -Permutation group of degree 8 and order 8 +Permutation group of degree 4 and order 8 julia> for g in all_transitive_groups(degree => 3:9, !is_primitive) h = image(optimal_perm_rep(g))[1]